Allow KAFKA_REST_INSTANCE_ID_VARIABLE which will be deferenced #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, if you're running this on Marathon where you get a MESOS_TASK_ID variable, you can pass in `KAFKA_REST_INSTANCE_ID_VARIABLE=MESOS_TASK_ID` which will then be deferenced to set `KAFKA_REST_INSTANCE_ID=[value of $MESOS_TASK_ID]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I figure you weren't intending for someone to find your kafka-rest docker project, but it's actually doing pretty well for itself as a google result for "kafka-rest docker".
Anyway, we run our Docker stuff using Marathon, which provides a
MESOS_TASK_IDvariable that I'd like to use for the instance ID. I added this little hack to allow starting the container like--env KAFKA_REST_INSTANCE_ID_VARIABLE=MESOS_TASK_IDand then the bash script dereferences it to set the instance ID to the value of MESOS_TASK_ID. It works pretty well for me.Dunno if you want this or not, but here it is anyway. Cheers!